feat(bench): evaluate review writing in ReviewBench #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 70.13% 63.87% -6.26%
==========================================
Files 80 82 +2
Lines 3569 3900 +331
==========================================
- Hits 2503 2491 -12
- Misses 1066 1409 +343
|
|
@timsanders256 is this PR ready to merge now? |
lwaekfjlk
changed the title
lwaekfjlk
requested changes
Dec 31, 2024
| ) | ||
| self.rebuttals.append(rebuttal) | ||
| yield rebuttal, self.leader | ||
| # self.rebuttals: List[Rebuttal] = [] |
There was a problem hiding this comment.
delete this directly instead of commenting.
| print(f'Token input count: {token_input_count}') | ||
| print(f'Token output count: {token_output_count}') | ||
|
|
||
| # # save all inputs and outputs |
| token_output_count += token_counter(model=model_name, text=strength) | ||
| token_output_count += token_counter(model=model_name, text=weakness) | ||
|
|
||
| # # save all inputs and outputs |
lwaekfjlk
changed the title
lwaekfjlk
approved these changes
Jan 1, 2025
lwaekfjlk
reviewed
Jan 1, 2025
| generated_weakness: str, | ||
| ) -> Dict[str, List[float]]: | ||
| metrics_raw: Dict[str, Any] = { | ||
| # 'bleu': [], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
π Description
β Checks
type/descript(e.g.feature/add-llm-agents)βΉ Additional Information